contributor-assistant/github-action
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update CONTRIBUTING.md

Browse Source
This commit is contained in:
Akshay Iyyadurai Balasundaram
2020-02-13 11:21:52 +01:00
committed by GitHub
parent bdcf0605e8
commit 50b681b94f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CONTRIBUTING.md
+2 -2
View File
@@ -111,8 +111,8 @@ These are some of the rules we try to follow:
- Apply a clean coding style adapted to the surrounding code, even though we are aware the existing code is not fully clean
- Use (4)spaces for indentation (except if the modified file consistently uses tabs)
- Use variable naming conventions like in the other files you are seeing (camelcase)
- No console.log() - use logging service
- Run the ESLint code check and make it succeed
- No console.log() - instead use GitHub Action Native logging service (For example `core.info("Hello World")`)
- Run the TSLint code check and make it succeed
- Comment your code where it gets non-trivial
- Keep an eye on performance and memory consumption, properly destroy objects when not used anymore
- Write a unit test