Files
Johan NestaasandCursor 6f3c981e7b
Lint / golangci-lint (push) Waiting to run
Lint / man-page-staleness (push) Waiting to run
Lint / semgrep (push) Waiting to run
Lint / checksecretparts (push) Waiting to run
Scan for secrets / test (push) Waiting to run
Test / test (push) Waiting to run
Test / test-community (push) Waiting to run
Release / mark-latest (push) Canceled after 0s
Release / Release (push) Canceled after 0s
fix(handlers): apk handler now doesnt check for apk extension since json-enumerator and other byte stream methods wouldnt have it (#5151)
* fix(handlers): apk handler now doesnt check for apk extension since json-enumerator and other byte stream methods wouldnt have it

* fix(handlers): don't fail zip/jar processing when APK check errors

Content-based APK detection now runs isAPKFile on every zip/jar (not just
.apk-named files). Previously a zip.NewReader failure (truncated zip,
corrupted central directory, or a polyglot mimetype still reports as zip)
was returned as a fatal error from newFileReader, causing HandleFile to
skip the file entirely. Treat the APK check error as non-fatal: log at V(3)
and fall through to the archive/default handler.

Also remove the now-dead readerConfig/readerOption/withFileExtension and
getFileExtension infrastructure left unused after shouldHandleAsAPK stopped
consuming the file extension.

Co-authored-by: Cursor <[email protected]>

---------

Co-authored-by: Cursor <[email protected]>
2026-07-24 10:38:46 -07:00
..