* JDBC test and parsing improvements - Uses net/url for more robust URI parsing - Supports common JDBC formats for MySQL - Supports URI format for MSSQL - Uses allowlist for params across all drivers - Uses testcontainers-go for integration testing - much faster, more robust, no port collisions - Uses gofakeit for random data (db, user, password) generation in integration tests - Adds connection timeouts - Use Microsoft's driver for MSSQL * go mod tidy
213 lines
6.2 KiB
Go
213 lines
6.2 KiB
Go
//go:build detectors
|
|
// +build detectors
|
|
|
|
package sqlserver
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/google/go-cmp/cmp/cmpopts"
|
|
"github.com/microsoft/go-mssqldb/msdsn"
|
|
|
|
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
|
|
"github.com/trufflesecurity/trufflehog/v3/pkg/pb/detectorspb"
|
|
)
|
|
|
|
func TestSQLServer_FromChunk(t *testing.T) {
|
|
secret := "Server=localhost;Initial Catalog=Demo;User ID=sa;Password=P@ssw0rd!;Persist Security Info=true;MultipleActiveResultSets=true;"
|
|
inactiveSecret := "Server=localhost;User ID=sa;Password=123"
|
|
|
|
type args struct {
|
|
ctx context.Context
|
|
data []byte
|
|
verify bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
s Scanner
|
|
args args
|
|
want []detectors.Result
|
|
wantErr bool
|
|
mockFunc func()
|
|
}{
|
|
{
|
|
name: "found, verified",
|
|
s: Scanner{},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
data: []byte(fmt.Sprintf("You can find a sqlserver secret %s within", secret)),
|
|
verify: true,
|
|
},
|
|
want: []detectors.Result{
|
|
{
|
|
DetectorType: detectorspb.DetectorType_SQLServer,
|
|
Redacted: "sqlserver://sa:********@localhost?database=Demo&dial+timeout=15&disableretry=false",
|
|
Verified: true,
|
|
},
|
|
},
|
|
wantErr: false,
|
|
mockFunc: func() {
|
|
ping = func(config msdsn.Config) (bool, error) {
|
|
return true, nil
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "found, unverified",
|
|
s: Scanner{},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
data: []byte(fmt.Sprintf("You can find a sqlserver secret %s within but not valid", inactiveSecret)), // the secret would satisfy the regex but not pass validation
|
|
verify: true,
|
|
},
|
|
want: []detectors.Result{
|
|
{
|
|
DetectorType: detectorspb.DetectorType_SQLServer,
|
|
Redacted: "sqlserver://sa:********@localhost?dial+timeout=15&disableretry=false",
|
|
Verified: false,
|
|
},
|
|
},
|
|
wantErr: false,
|
|
mockFunc: func() {
|
|
ping = func(config msdsn.Config) (bool, error) {
|
|
return false, nil
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "not found, in XML, missing password param (pwd is not valid)",
|
|
s: Scanner{},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
data: []byte(`<add name="Sample2" value="SERVER=server_name;DATABASE=database_name;user=user_name;pwd=plaintextpassword;encrypt=true;Timeout=120;MultipleActiveResultSets=True;" />`),
|
|
verify: true,
|
|
},
|
|
want: nil,
|
|
wantErr: false,
|
|
mockFunc: func() {
|
|
ping = func(config msdsn.Config) (bool, error) {
|
|
return true, nil
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "found, verified, in XML",
|
|
s: Scanner{},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
data: []byte(`<add name="test db" value="SERVER=server_name;DATABASE=testdb;user=username;password=badpassword;encrypt=true;Timeout=120;MultipleActiveResultSets=True;" />`),
|
|
verify: true,
|
|
},
|
|
want: []detectors.Result{
|
|
{
|
|
DetectorType: detectorspb.DetectorType_SQLServer,
|
|
Redacted: "sqlserver://username:********@server_name?database=testdb&dial+timeout=15&disableretry=false&encrypt=true",
|
|
Verified: true,
|
|
},
|
|
},
|
|
wantErr: false,
|
|
mockFunc: func() {
|
|
ping = func(config msdsn.Config) (bool, error) {
|
|
if config.Host != "server_name" {
|
|
return false, errors.New("invalid host")
|
|
}
|
|
|
|
if config.User != "username" {
|
|
return false, errors.New("invalid database")
|
|
}
|
|
|
|
if config.Password != "badpassword" {
|
|
return false, errors.New("invalid password")
|
|
}
|
|
|
|
if config.Database != "testdb" {
|
|
return false, errors.New("invalid database")
|
|
}
|
|
|
|
return true, nil
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "not found",
|
|
s: Scanner{},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
data: []byte("You cannot find the secret within"),
|
|
verify: true,
|
|
},
|
|
want: nil,
|
|
wantErr: false,
|
|
mockFunc: func() {},
|
|
},
|
|
}
|
|
|
|
// preserve the original function
|
|
originalPing := ping
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
tt.mockFunc()
|
|
s := Scanner{}
|
|
got, err := s.FromData(tt.args.ctx, tt.args.verify, tt.args.data)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("SQLServer.FromData() error = %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
for i := range got {
|
|
if len(got[i].Raw) == 0 {
|
|
t.Fatalf("no raw secret present: \n %+v", got[i])
|
|
}
|
|
got[i].Raw = nil
|
|
}
|
|
ignoreOpts := []cmp.Option{
|
|
cmpopts.IgnoreFields(detectors.Result{}, "RawV2"),
|
|
cmpopts.IgnoreUnexported(detectors.Result{}),
|
|
}
|
|
if diff := cmp.Diff(tt.want, got, ignoreOpts...); diff != "" {
|
|
t.Errorf("SQLServer.FromData() %s diff: (-got +want)\n%s", tt.name, diff)
|
|
for _, g := range got {
|
|
t.Error(g.Redacted)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
|
|
ping = originalPing
|
|
}
|
|
|
|
func TestSQLServer_pattern(t *testing.T) {
|
|
if !pattern.Match([]byte(`builder.Services.AddDbContext<Database>(optionsBuilder => optionsBuilder.UseSqlServer("Server=localhost;Initial Catalog=master;User ID=sa;Password=P@ssw0rd!;Persist Security Info=true;MultipleActiveResultSets=true;"));`)) {
|
|
t.Errorf("SQLServer.pattern: did not find connection string from Program.cs")
|
|
}
|
|
if !pattern.Match([]byte(`{"ConnectionStrings": {"Demo": "Server=localhost;Initial Catalog=master;User ID=sa;Password=P@ssw0rd!;Persist Security Info=true;MultipleActiveResultSets=true;"}}`)) {
|
|
t.Errorf("SQLServer.pattern: did not find connection string from appsettings.json")
|
|
}
|
|
if !pattern.Match([]byte(`CONNECTION_STRING: Server=localhost;Initial Catalog=master;User ID=sa;Password=P@ssw0rd!;Persist Security Info=true;MultipleActiveResultSets=true`)) {
|
|
t.Errorf("SQLServer.pattern: did not find connection string from .env")
|
|
}
|
|
if !pattern.Match([]byte(`<add name="Sample2" value="SERVER=server_name;DATABASE=database_name;user=user_name;pwd=plaintextpassword;encrypt=true;Timeout=120;MultipleActiveResultSets=True;" />`)) {
|
|
t.Errorf("SQLServer.pattern: did not find connection string in xml format")
|
|
}
|
|
}
|
|
|
|
func BenchmarkFromData(benchmark *testing.B) {
|
|
ctx := context.Background()
|
|
s := Scanner{}
|
|
for name, data := range detectors.MustGetBenchmarkData() {
|
|
benchmark.Run(name, func(b *testing.B) {
|
|
b.ResetTimer()
|
|
for n := 0; n < b.N; n++ {
|
|
_, err := s.FromData(ctx, false, data)
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|