From c2ae31d06077155dda16eec3dd85a0e46c431629 Mon Sep 17 00:00:00 2001 From: Dustin Decker Date: Thu, 1 Feb 2024 08:40:44 -0800 Subject: [PATCH] Make AzureDevopsPersonalAccessToken verification more robust (#2359) * Make AzureDevopsPersonalAccessToken verification more robust * fix snifftest --- hack/snifftest/snifftest.sh | 2 +- .../azuredevopspersonalaccesstoken.go | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hack/snifftest/snifftest.sh b/hack/snifftest/snifftest.sh index 04e1bd6eb..f17b04dfb 100755 --- a/hack/snifftest/snifftest.sh +++ b/hack/snifftest/snifftest.sh @@ -1,7 +1,7 @@ #!/usr/bin/env bash REPO_ARRAY=( - # "https://github.com/Netflix/Hystrix.git" + "https://github.com/Netflix/Hystrix.git" # "https://github.com/facebook/flow.git" # "https://github.com/Netflix/vizceral.git" # "https://github.com/Netflix/metaflow.git" diff --git a/pkg/detectors/azuredevopspersonalaccesstoken/azuredevopspersonalaccesstoken.go b/pkg/detectors/azuredevopspersonalaccesstoken/azuredevopspersonalaccesstoken.go index c1a50ae76..d6a3bb537 100644 --- a/pkg/detectors/azuredevopspersonalaccesstoken/azuredevopspersonalaccesstoken.go +++ b/pkg/detectors/azuredevopspersonalaccesstoken/azuredevopspersonalaccesstoken.go @@ -69,7 +69,8 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result res, err := client.Do(req) if err == nil { defer res.Body.Close() - if res.StatusCode >= 200 && res.StatusCode < 300 { + hasVerifiedRes, _ := common.ResponseContainsSubstring(res.Body, "lastUpdateTime") + if res.StatusCode >= 200 && res.StatusCode < 300 && hasVerifiedRes { s1.Verified = true } else if res.StatusCode == 401 { // The secret is determinately not verified (nothing to do)