From 9f99ee470dd63c3c2cc2f825f7177f10658e30b6 Mon Sep 17 00:00:00 2001 From: Bill Rich Date: Tue, 6 Dec 2022 08:42:24 -0800 Subject: [PATCH] Integration test fixes (#956) * Adjust repo count for new app * Fix chunk test count --- go.mod | 2 +- go.sum | 6 ++---- pkg/sources/chunker_test.go | 4 ++-- pkg/sources/github/github_integration_test.go | 2 +- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/go.mod b/go.mod index db249240b..42d9bc44d 100644 --- a/go.mod +++ b/go.mod @@ -13,7 +13,7 @@ require ( github.com/Azure/go-autorest/autorest/azure/auth v0.5.11 github.com/TheZeroSlave/zapsentry v1.12.0 github.com/aws/aws-sdk-go v1.44.83 - github.com/bill-rich/disk-buffer-reader v0.1.5 + github.com/bill-rich/disk-buffer-reader v0.1.6 github.com/bill-rich/go-syslog v0.0.0-20220413021637-49edb52a574c github.com/bitfinexcom/bitfinex-api-go v0.0.0-20210608095005-9e0b26f200fb github.com/bradleyfalzon/ghinstallation/v2 v2.1.0 diff --git a/go.sum b/go.sum index 41bb3db51..05c30730c 100644 --- a/go.sum +++ b/go.sum @@ -94,10 +94,8 @@ github.com/aws/aws-sdk-go v1.44.83 h1:7+Rtc2Eio6EKUNoZeMV/IVxzVrY5oBQcNPtCcgIHYJ github.com/aws/aws-sdk-go v1.44.83/go.mod h1:y4AeaBuwd2Lk+GepC1E9v0qOiTws0MIWAX4oIKwKHZo= github.com/benbjohnson/clock v1.1.0 h1:Q92kusRqC1XV2MjkWETPvjJVqKetz1OzxZB7mHJLju8= github.com/benbjohnson/clock v1.1.0/go.mod h1:J11/hYXuz8f4ySSvYwY0FKfm+ezbsZBKZxNJlLklBHA= -github.com/bill-rich/disk-buffer-reader v0.1.4 h1:boaUh/NBiTGyH/ZmJvBE48CqK3UAsnezkONE4GT7H1w= -github.com/bill-rich/disk-buffer-reader v0.1.4/go.mod h1:VVzzsK1Ac2AnpOfp/5r9JlIFaFkZ9uSf7zisZayCt0Y= -github.com/bill-rich/disk-buffer-reader v0.1.5 h1:XJcEjqE9nVzFinQpVFVGF+fK2Zv2Pl5LQVkmC9p/aaA= -github.com/bill-rich/disk-buffer-reader v0.1.5/go.mod h1:VVzzsK1Ac2AnpOfp/5r9JlIFaFkZ9uSf7zisZayCt0Y= +github.com/bill-rich/disk-buffer-reader v0.1.6 h1:4e2q22GPlYFBLSuxm2Af10C89DaUEVTTrUBWKdkMPGg= +github.com/bill-rich/disk-buffer-reader v0.1.6/go.mod h1:VVzzsK1Ac2AnpOfp/5r9JlIFaFkZ9uSf7zisZayCt0Y= github.com/bill-rich/go-syslog v0.0.0-20220413021637-49edb52a574c h1:tSME5FDS02qQll3JYodI6RZR/g4EKOHApGv1wMZT+Z0= github.com/bill-rich/go-syslog v0.0.0-20220413021637-49edb52a574c/go.mod h1:+sCc6hztur+oZCLOsNk6wCCy+GLrnSNHSRmTnnL+8iQ= github.com/bitfinexcom/bitfinex-api-go v0.0.0-20210608095005-9e0b26f200fb h1:9v7Bzlg+1EBYi2IYcUmOwHReBEfqBbYIj3ZCi9cIe1Q= diff --git a/pkg/sources/chunker_test.go b/pkg/sources/chunker_test.go index b17ae43e9..0a3755820 100644 --- a/pkg/sources/chunker_test.go +++ b/pkg/sources/chunker_test.go @@ -27,15 +27,15 @@ func TestChunker(t *testing.T) { // Count chunks from looping using chunk size. for { - baseChunkCount++ tmpChunk := make([]byte, ChunkSize) _, err := reReader.Read(tmpChunk) if err != nil { if errors.Is(err, io.EOF) { break } - t.Error(err) + t.Fatal(err) } + baseChunkCount++ } _ = reReader.Reset() diff --git a/pkg/sources/github/github_integration_test.go b/pkg/sources/github/github_integration_test.go index 70782c81a..64a29634c 100644 --- a/pkg/sources/github/github_integration_test.go +++ b/pkg/sources/github/github_integration_test.go @@ -384,7 +384,7 @@ func TestSource_Scan(t *testing.T) { }, wantChunk: nil, wantErr: false, - minRepo: 3, + minRepo: 1, minOrg: 1, }, }