From 9c2d55b04c282533481ed44cf7886498bc8276ba Mon Sep 17 00:00:00 2001 From: Charlie Gunyon Date: Thu, 8 May 2025 14:28:38 +0200 Subject: [PATCH] Make SimpleRateLimit even simpler --- pkg/sources/rate_limiter/simple_rate_limit.go | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/pkg/sources/rate_limiter/simple_rate_limit.go b/pkg/sources/rate_limiter/simple_rate_limit.go index 1272be525..9c6955b13 100644 --- a/pkg/sources/rate_limiter/simple_rate_limit.go +++ b/pkg/sources/rate_limiter/simple_rate_limit.go @@ -8,16 +8,13 @@ import ( "golang.org/x/time/rate" ) -// SimpleRateLimit implements a basic "requests per second with bursting" -// rate limiter. It's a (very) thin wrapper around Google's rate limiter with -// a hardcoded burst rate of 1. +// SimpleRateLimit implements a basic "requests per second" rate limiter. It's +// a (very) thin wrapper around Google's rate limiter with a hardcoded burst +// rate of 1. type SimpleRateLimit struct { limiter *rate.Limiter } -// Creates a new SimpleRateLimit -// lim: a Limit representing the max number of requests per second -// burst: max number of requests that can be sent if any requests can be sent func NewSimpleRateLimit(requestsPerSecond int) *SimpleRateLimit { lim := rate.Every(time.Second / time.Duration(requestsPerSecond)) return &SimpleRateLimit{ @@ -30,10 +27,6 @@ func (tp *SimpleRateLimit) MaybeWait( req *http.Request, now time.Time, ) error { - if err := ctx.Err(); err != nil { - return err - } - return tp.limiter.Wait(ctx) }