From f14eba91e23b7dec7c2cfdeeedbb569261d8740c Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Tue, 25 Feb 2025 14:12:14 +0100 Subject: [PATCH] Allow linting in parallel --- .github/workflows/build.yml | 12 ++++-------- action.yml | 3 ++- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 902ee31..3a9cb5d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -40,13 +40,6 @@ jobs: with: fetch-depth: 0 - - name: Set git user to getsentry-bot - if: github.ref == 'refs/heads/master' - run: | - echo "GIT_COMMITTER_NAME=getsentry-bot" >> $GITHUB_ENV; - echo "GIT_AUTHOR_NAME=getsentry-bot" >> $GITHUB_ENV; - echo "EMAIL=bot@sentry.io" >> $GITHUB_ENV; - - name: Evaluate docker tag run: | if [[ "${{ github.ref }}" == "refs/heads/master" ]]; then @@ -54,6 +47,10 @@ jobs: yarn set-docker-tag master if ! git diff --quiet action.yml; then + echo "GIT_COMMITTER_NAME=getsentry-bot" >> $GITHUB_ENV; + echo "GIT_AUTHOR_NAME=getsentry-bot" >> $GITHUB_ENV; + echo "EMAIL=bot@sentry.io" >> $GITHUB_ENV; + git add action.yml git commit -m "chore: Set docker tag for master [skip-ci]" git push @@ -102,7 +99,6 @@ jobs: build-args: BUILDKIT_INLINE_CACHE=1 lint: - needs: docker-build runs-on: ubuntu-latest steps: diff --git a/action.yml b/action.yml index 916c390..918e187 100644 --- a/action.yml +++ b/action.yml @@ -88,7 +88,8 @@ runs: # For actions running on macos or windows runners, we use a composite # action approach which allows us to install the arch specific sentry-cli - # binary that's needed for the runner. This is slower. + # binary that's needed for the runner. + # This is slower than the docker approach but runs on macos and windows. - name: Mark GitHub workspace a safe directory in git if: ${{ (runner.os == 'macOS' || runner.os == 'Windows') && inputs.disable_safe_directory != 'true' }} shell: bash