From edeb57f200ef92c01dcdf77fa90616ed038ebcf5 Mon Sep 17 00:00:00 2001 From: Valerio Setti Date: Wed, 9 Sep 2026 10:10:04 +0200 Subject: [PATCH] crypto_knowledge: improve return values for get_inner_algorithm() Return a ValueError exception instead of None if the given algorithm is not a composed one. Signed-off-by: Valerio Setti --- scripts/mbedtls_framework/crypto_knowledge.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/mbedtls_framework/crypto_knowledge.py b/scripts/mbedtls_framework/crypto_knowledge.py index 3f01b349e..ee4a98125 100644 --- a/scripts/mbedtls_framework/crypto_knowledge.py +++ b/scripts/mbedtls_framework/crypto_knowledge.py @@ -505,10 +505,13 @@ class Algorithm: return True def get_inner_algorithm(self) -> "Algorithm": - """Given an algorithm composed as outer_alg(inner_alg) return inner_alg.""" + """Given an algorithm composed as outer_alg(inner_alg) return inner_alg. + + Raise ValueError if the algorithm is not a composed one. + """ m = re.match(r'\w+\(\s*(.*)\)\Z', self.expression) if not m: - return None + raise ValueError('Not a composed algorithm: ' + self.expression) inner_alg = m.group(1) return Algorithm(inner_alg)